Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Mar 19, 2025

Add SMS Country Selection for In-App Wallets

This PR adds support for configuring SMS-enabled countries for In-App Wallets. It includes:

  • A new country selector UI component that allows users to select which countries can use SMS authentication
  • Integration with the SMS country tiers API to fetch available countries and their pricing tiers
  • Exposure of smsEnabledCountryISOs in the project API response
  • Default selection of US and Canada when SMS is enabled

The UI organizes countries into 5 pricing tiers, from included (Tier 1) to premium rates (Tier 5), with clear pricing displayed for each tier. Users can select individual countries or entire tiers at once.


PR-Codex overview

This PR introduces SMS functionality, enabling users to log in via SMS in selected countries. It adds validation for SMS-enabled countries and integrates a country selection UI for SMS features.

Detailed summary

  • Added smsEnabledCountryISOs to API response and validation schema.
  • Implemented getSMSCountryTiers API call to fetch SMS country tiers.
  • Created CountrySelector component for selecting SMS-enabled countries.
  • Updated InAppWalletSettingsPage to utilize SMS country tiers.
  • Enhanced UI to allow SMS login feature configuration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 11:07pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 11:07pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 11:07pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 11:07pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 11:07pm

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: 0edfaec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Mar 19, 2025
Copy link
Member Author

jnsdls commented Mar 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.78%. Comparing base (639b542) to head (0edfaec).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6502   +/-   ##
=======================================
  Coverage   54.78%   54.78%           
=======================================
  Files         875      875           
  Lines       54903    54903           
  Branches     3745     3745           
=======================================
  Hits        30077    30077           
  Misses      24731    24731           
  Partials       95       95           
Flag Coverage Δ
packages 54.78% <ø> (ø)

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.92 KB (0%) 939 ms (0%) 170 ms (+127.82% 🔺) 1.2 s
thirdweb (cjs) 127.17 KB (0%) 2.6 s (0%) 306 ms (+23.53% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 76 ms (+692.29% 🔺) 188 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 35 ms (+1398.68% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 87 ms (+410.48% 🔺) 474 ms

@jnsdls jnsdls merged commit f81fd46 into main Mar 20, 2025
33 checks passed
@jnsdls jnsdls deleted the add_SMS_country_selection_for_in-app_wallets branch March 20, 2025 00:30
@joaquim-verges joaquim-verges mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants